[COLLECTIONS-540] Duplication of code in CollectionUtils

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 4.0
• Fix Version/s: 4.1
• Assignee: Unassigned
• Reporter: Daniel Stewart
• Created: 25/Dec/14 02:36
• Updated: 27/Nov/15 21:11
• Resolved: 26/Dec/14 11:07

Description

In CollectionUtils.get(Object, int) on Line 1250, the code in the condition:

CollectionUtils.java

else if (object instanceof Iterator<?>) {
    final Iterator<?> it = (Iterator<?>) object;
    while (it.hasNext()) {
        i--;
        if (i == -1) {
            return it.next();
        }
        it.next();
     }
     throw new IndexOutOfBoundsException("Entry does not exist: " + i);
}

Can be replaced with just a call to CollectionUtils.get(Iterator, int), on Line 1176.