[COLLECTIONS-473] AbstractCollectionDecorator.decorated() should not be used internally

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 17/Jun/13 22:17
• Updated: 09/Nov/14 14:31
• Resolved: 18/Jun/13 20:29

Description

AbstractCollectionDecorator.decorated() is used internally to access the collection.
However, the method is not final, so subclasses could override it.

Yet the field is also exposed (protected).

This is inconsistent.

Is there any use-case for overriding the collection to use a different one?
If so, having direct access as well is likely to cause problems.

I think it would be better to use the field directly internally.
The class Javadoc says the calls are forwarded to the underlying collection, but that is not strictly true if decorated() is overridden.

If it is intended to allow this to be overridden, then the field needs to be protected against arbitrary read/write access.

The field should probably be made private with a setter for use by deserialization only.