Uploaded image for project: 'Commons Collections'
  1. Commons Collections
  2. COLLECTIONS-232

Some tests contain assertEquals arguments in the incorrect order

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 4.0
    • None
    • None

    Description

      A few tests have the expected and actual arguments to assertEquals in the wrong order. This can lead to very confusing failure messages. I'll attach a patch to fix some of the more obvious ones. I've also replaced a couple of assertTrue(blah.size() == 0) with assertEquals(0, blah.size()) since the later typically gives a more helpful failure message.

      Attachments

        1. fix.assertEquals.usage.diff
          20 kB
          Mark Hindess

        Activity

          People

            Unassigned Unassigned
            hindessm Mark Hindess
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: