Base64's new constructor parameters ignored

• Key: CODEC-81
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Trivial
• Assignee: Unassigned
• Reporter: Julius Davies
• Affects Version/s: Nightly Builds
• Fix Version/s: 1.4

Description

Base64's new constructor parameters are ignored (e.g. chunkSize and chunkSeparator) when using the Encoder interface.

Comments

[Julius Davies]

Two patches attached:

1. codec81-junit.patch highlights the bug.
2. codec81-fix.patch fixes the bug.

There's a tiny bit of code cleanup in there anticipating my next attempt at a CODEC-59 patch - in particular this, since hopefully "instanceof String" will become a valid Object type to decode.

-         if (!(pObject instanceof byte[])) {
+        if (pObject instanceof byte[]) {
+            return decode((byte[]) pObject);
+        } else {
             throw new DecoderException("Parameter supplied to Base64 decode is not a byte[]");
          }

[Julius Davies]

FYI: the "codec81-fix.patch" fix moves all the logic in the two main "public static" methods into member methods instead.

[Gary Gregory]

The patch line:

desiredResult = desiredResult.replace("=", ""); // url-safe has no == padding.

uses a Java 1.5 String API, we are not on 1.5 yet, but we just moved to 1.4.

Can you please re-patch?

Thank you.

[Julius Davies]

Whoops! Previous was not Java1.4 compatible. Sorry!

[Gary Gregory]

Patch applied and then some.