[#CODEC-72] Soundex and RefinedSoundex issues with character arrays

Commons Codec

Soundex and RefinedSoundex issues with character arrays

Created: 06/Jul/08 12:36 PM Updated: 24/Mar/09 07:19 AM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

1.4

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	soundex.patch	2008-07-06 01:10 PM	Sebb	6 kB

Resolution Date:

24/Mar/09 07:19 AM

Description

« Hide

Soundex and RefinedSoundex both have public US_ENGLISH_MAPPING char arrays. These don't appear to be used externally, so should be made private - or at least package protected.

Also, the class constructors store externally mutable char arrays; it would be better if these were copied.

Patch to follow.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

No work has yet been logged on this issue.