Uploaded image for project: 'Cocoon'
  1. Cocoon
  2. COCOON-1979

[PATCH] Flow 2.1.0 reload-script = true does not reload scripts loaded via cocoon.load

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.1.10
    • 2.1.11, 2.2
    • * Cocoon Core
    • None
    • Normal
    • Patch available

    Description

      When a script is loaded via cocoon.load the refresh parameter for CompilingInterpreter.ScripSourceEntry.getScript is always set to false. In 2.1.8 this parameter was incorrectly ignored, when checking the compile time against the last modified time in CompilingInterpreter.ScripSourceEntry.getScript. This was corrected in 2.19 or 2.1.10. The side effect however is that scripts loaded via cocoon.load are never checked for modification, as FOM_JavaScriptInterpreter.compileScript(Context, String) always calls the getScript method with refresh = false.
      In the supplied patched (patch-1.txt and patch-2.txt) the compileScript method now sets the refresh indicator dependent on the reload-script and check-time parameters.

      Attachments

        1. patch-1.txt
          1.0 kB
          Rob Berens
        2. patch-2.txt
          1.0 kB
          Rob Berens

        Activity

          People

            cziegeler Carsten Ziegeler
            rberens@osirion.nl Rob Berens
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: