[#CHAIN-42] Various scope mappers use incorrect equalization

Commons Chain

Various scope mappers use incorrect equalization

Created: 01/Dec/07 11:35 AM Updated: 20/May/08 05:27 PM

Return to search

Component/s:

None

Affects Version/s:

1.1

Fix Version/s:

1.2

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	patch-equals.txt	2007-12-01 11:40 AM	Isaac Shabtay	5 kB

Environment:

All

Resolution Date:

20/May/08 05:27 PM

Description

« Hide

The following classes:

org.apache.commons.chain.web.portlet.PortletApplicationScopeMap
org.apache.commons.chain.web.portlet.PortletRequestScopeMap
org.apache.commons.chain.web.portlet.PortletSessionScopeMap
org.apache.commons.chain.web.servlet.ServletApplicationScopeMap
org.apache.commons.chain.web.servlet.ServletRequestScopeMap
org.apache.commons.chain.web.servlet.ServletSessionScopeMap

use the "==" for comparison in their containsValue(Object) methods. This is in contrary to java.util.Map's specification which mandates that the containsValue(v1) method returns true if and only if there exists a value 'v' in the map such that v1.equals(v).

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Isaac Shabtay added a comment - 01/Dec/07 11:40 AM

Proposed patch. Note that in none of the cases can "value" be null, so an NPE shouldn't happen.

Isaac Shabtay made changes - 01/Dec/07 11:40 AM

Field	Original Value	New Value
Attachment		patch-equals.txt [ 12370741 ]

Repository	Revision	Date	User	Message
ASF	#658355	Tue May 20 17:25:51 UTC 2008	niallp	~~CHAIN-42~~ - Various scope mappers use incorrect equalization - thanks to Isaac Shabtay for the patch
				Files Changed
				MODIFY /commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletSessionScopeMap.java MODIFY /commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/servlet/ServletSessionScopeMap.java MODIFY /commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java MODIFY /commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/portlet/PortletRequestScopeMap.java MODIFY /commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/servlet/ServletApplicationScopeMap.java MODIFY /commons/proper/chain/trunk/src/java/org/apache/commons/chain/web/servlet/ServletRequestScopeMap.java MODIFY /commons/proper/chain/trunk/xdocs/changes.xml

Niall Pemberton made changes - 20/May/08 05:26 PM

Affects Version/s

1.2 [ 12311963 ]

[ Permlink | « Hide ]

Niall Pemberton added a comment - 20/May/08 05:27 PM

Fixed, thanks for the patch

http://svn.apache.org/viewvc?view=rev&revision=658355

Niall Pemberton made changes - 20/May/08 05:27 PM

Resolution		Fixed [ 1 ]
Fix Version/s		1.2 [ 12311963 ]
Assignee		Niall Pemberton [ niallp ]
Status	Open [ 1 ]	Resolved [ 5 ]