Improve DBCPDataSourceFactory to use it for a JettyPlus DataSource

• Key: CAY-702
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Andrus Adamchik
• Component/s: Cayenne Core Library
• Affects Version/s: 3.0
• Fix Version/s: 3.0M1

Description

Tried using DBCPDataSourceFactory to map a Jetty 5.1.11 DataSource (as the default Cayenne PoolManager doesn't have connection validation feature), and ran into an NPE since it expected a Configuration object:

<New class="org.apache.cayenne.conf.DBCPDataSourceFactory">
   <Call name="getDataSource" id="dataSource">
       <Arg>etc/dbcp.properties</Arg>

    </Call>
  </New>

  
  <Call name="addService">
    <Arg>
      <New class="org.mortbay.jetty.plus.DefaultDataSourceService">
        <Set name="Name">DataSourceService</Set>
         <Call name="addDataSource">
             <Arg>jdbc/myDataSource</Arg>
             <Arg>
               <Ref id="dataSource"/>
             </Arg>
         </Call>
       </New>
     </Arg>
   </Call>


java.lang.NullPointerException
        at org.apache.cayenne.conf.DBCPDataSourceFactory.getDataSource(DBCPDataSourceFactory.java:67)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)
        at org.mortbay.xml.XmlConfiguration.call(XmlConfiguration.java:540)

Comments

Closing all 3.0 issues marked as resolved as of 11/22 - I logged a list of them in release notes.