Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-7837 Factor out static initialization / singletons
  3. CASSANDRA-7840

Refactor static state & functions into static singletons

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Normal
    • Resolution: Later
    • 3.11.5
    • None
    • None

    Description

      1st step of CASSANDRA-7837.

      Things like DatabaseDescriptor.getPartitioner() should become DatabaseDescriptor.instance.getPartitioner(). In cases where there is a mix of instance state and static functionality (Keyspace & ColumnFamilyStore classes), the static portion should be split off into singleton factory classes.

      Attachments

        1. 0001-splitting-StorageService-executors-into-a-separate-c.patch
          24 kB
          Blake Eggleston
        2. 0002-making-DatabaseDescriptor-a-singleton.patch
          274 kB
          Blake Eggleston
        3. 0003-refactoring-StorageService-static-methods.patch
          75 kB
          Blake Eggleston
        4. 0004-making-StorageProxy-a-singleton.patch
          55 kB
          Blake Eggleston
        5. 0005-making-MigrationManager-a-singleton.patch
          47 kB
          Blake Eggleston
        6. 0006-making-SystemKeyspace-a-singleton.patch
          93 kB
          Blake Eggleston
        7. 0007-making-Auth-a-singleton.patch
          23 kB
          Blake Eggleston
        8. 0008-removing-static-methods-and-initialization-from-Comp.patch
          6 kB
          Blake Eggleston
        9. 0009-making-SinkManager-a-singleton.patch
          8 kB
          Blake Eggleston
        10. 0010-making-DefsTables-a-singleton.patch
          13 kB
          Blake Eggleston
        11. 0011-making-StageManager-a-singleton.patch
          27 kB
          Blake Eggleston
        12. 0012-making-MessagingService-a-singleton.patch
          79 kB
          Blake Eggleston
        13. 0013-making-QueryProcessor-a-singleton.patch
          98 kB
          Blake Eggleston
        14. 0014-refactoring-static-methods-on-Tracing.patch
          59 kB
          Blake Eggleston
        15. 0015-removing-static-state-from-BatchlogManager.patch
          3 kB
          Blake Eggleston
        16. 0016-removing-static-method-from-CommitLog.patch
          3 kB
          Blake Eggleston
        17. 0017-OutboundTcpConnection-removing-singleton-access-from.patch
          3 kB
          Blake Eggleston
        18. 0018-FBUtilities-removing-getLocalAddress-getBroadcastAdd.patch
          114 kB
          Blake Eggleston
        19. 0019-PendingRangeCalculatorService-removing-singleton-acc.patch
          3 kB
          Blake Eggleston
        20. 0020-ActiveRepairService-removing-static-members-and-meth.patch
          8 kB
          Blake Eggleston
        21. 0021-RowDataResolver-removing-static-singleton-access-fro.patch
          4 kB
          Blake Eggleston
        22. 0022-AbstractReadExecutor-removing-static-method.patch
          1 kB
          Blake Eggleston
        23. 0023-StorageServiceAccessor-removing-static-singleton-acc.patch
          2 kB
          Blake Eggleston
        24. 0024-FileUtils-removing-static-singleton-accesses-from-st.patch
          4 kB
          Blake Eggleston
        25. 0025-ResourceWatcher-removing-static-singleton-access-fro.patch
          5 kB
          Blake Eggleston
        26. 0026-TokenMetadata-removing-static-singleton-access-from-.patch
          10 kB
          Blake Eggleston
        27. 0027-OutboundTcpConnectionPool-removing-static-singleton-.patch
          6 kB
          Blake Eggleston
        28. 0028-Cassandra-PasswordAuthenticator-making-static-method.patch
          2 kB
          Blake Eggleston
        29. 0029-CompactionMetrics-making-static-method-instance-meth.patch
          4 kB
          Blake Eggleston
        30. 0030-ClientState-splitting-configured-QueryHandler-instan.patch
          11 kB
          Blake Eggleston
        31. 0031-SSTableReader-splitting-static-factory-methods-into-.patch
          55 kB
          Blake Eggleston
        32. 0032-Keyspace-splitting-static-factory-methods-and-state-.patch
          227 kB
          Blake Eggleston
        33. 0033-ColumnFamilyStore-splitting-static-factory-methods-a.patch
          40 kB
          Blake Eggleston
        34. 0034-TriggerDefinition-removing-static-singleton-access-f.patch
          2 kB
          Blake Eggleston
        35. 0035-CFMetaData-splitting-off-static-factory-methods-onto.patch
          121 kB
          Blake Eggleston
        36. 0036-KSMetaData-splitting-off-static-factory-methods-onto.patch
          35 kB
          Blake Eggleston
        37. 0037-SystemKeyspace-moving-system-keyspace-definitions-on.patch
          57 kB
          Blake Eggleston
        38. 0038-UTMetaData-refactoring-static-singleton-accesses-for.patch
          15 kB
          Blake Eggleston
        39. 0039-CounterId-removing-static-singleton-accesses-from-st.patch
          10 kB
          Blake Eggleston
        40. 0040-AtomicBtreeColumns-replacing-SystemKeyspace-CFMetaDa.patch
          4 kB
          Blake Eggleston

        Issue Links

          links to

          Web Link GitHub Pull Request #

          Activity

            People

              bdeggleston Blake Eggleston
              bdeggleston Blake Eggleston
              Blake Eggleston
              Yuki Morishita
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: