[CASSANDRA-14281] Improve LatencyMetrics performance by reducing write path processing

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha1, 4.0
• Component/s: Feature/Lightweight Transactions, Legacy/Core
• Labels: LWT perfomance
• Assignee: Michael Burman
• Reporter: Michael Burman

Authors

Michael Burman

Reviewers

Chris Lohfink

• Created: 28/Feb/18 12:50
• Updated: 16/Mar/22 11:37
• Resolved: 25/Apr/18 04:01

Description

Currently for each write/read/rangequery/CAS touching the CFS we write a latency metric which takes a lot of processing time (up to 66% of the total processing time if the update was empty). 

The way latencies are recorded is to use both a dropwizard "Timer" as well as "Counter". Latter is used for totalLatency and the previous is decaying metric for rates and certain percentile metrics. We then replicate all of these CFS writes to the KeyspaceMetrics and globalWriteLatencies. 

Instead of doing this on the write phase we should merge the metrics when they're read. This is much less common occurrence and thus we save a lot of CPU time in total. This also speeds up the write path.

Currently, the DecayingEstimatedHistogramReservoir acquires a lock for each update operation, which causes a contention if there are more than one thread updating the histogram. This impacts scalability when using larger machines. We should make it lock-free as much as possible and also avoid a single CAS-update from blocking all the concurrent threads from making an update.

Issue Links

• is related to: CASSANDRA-15213 DecayingEstimatedHistogramReservoir Inefficiencies
• links to: GitHub Pull Request #217