[CASSANDRA-13356] BootstrapMonitor.progress does not store all error messages

• Type: Bug
• Status: Open
• Priority: Normal
• Resolution: Unresolved
• Fix Version/s: 5.x
• Component/s: Legacy/Tools
• Labels: lhf
• Severity: Normal
• Complexity: Low Hanging Fruit
• Assignee: Hao Zhong
• Reporter: Hao Zhong

Authors

Hao Zhong

Reviewers

Paulo Motta

• Created: 21/Mar/17 00:21
• Updated: 07/Mar/23 10:54

Description

The BootstrapMonitor.progress ignores error messages when an error is ProgressEventType.ERROR. Indeed, RepairRunner.progress once had a similar bug, but is fixed. The fixed code is:

 public void progress(String tag, ProgressEvent event)
    {
        ProgressEventType type = event.getType();
        String message = String.format("[%s] %s", format.format(System.currentTimeMillis()), event.getMessage());
        if (type == ProgressEventType.PROGRESS)
        {
            message = message + " (progress: " + (int)event.getProgressPercentage() + "%)";
        }
        out.println(message);
        if (type == ProgressEventType.ERROR)
        {
            error = new RuntimeException("Repair job has failed with the error message: " + message);
        }
        if (type == ProgressEventType.COMPLETE)
        {
            condition.signalAll();
        }
    }

Please refer to CASSANDRA-12508 for details.