[CASSANDRA-12516] Interned column identifiers can be overridden incorrectly

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.10, 3.10
• Component/s: Legacy/Local Write-Read Paths
• Severity: Normal
• Assignee: Stefania Alborghetti
• Reporter: Aleksey Yeschenko

Authors

Stefania Alborghetti

Reviewers

Aleksey Yeschenko

• Created: 22/Aug/16 14:03
• Updated: 16/Apr/19 09:30
• Resolved: 20/Sep/16 01:31

Description

As discovered by Stefania in CASSANDRA-12423, our use of ColumnIdentifier.internedInstances to map byte buffer column names to column identifiers is incorrect. It's possible for two non-equal ColumnIdentifier instances to have the same ByteBuffer as raw name, and yet different text representations, due to different column name types, leading to hard to debug correctness issues.

Should either amend the map to have the type as part of the key, or limit the use of that map.

Issue Links

• is related to: CASSANDRA-12423 Cells missing from compact storage table after upgrading from 2.1.9 to 3.7
• is related to: CASSANDRA-14468 "Unable to parse targets for index" on upgrade to Cassandra 3.0.10-3.0.16