[CALCITE-2565] Suspicious code in org.apache.calcite.rex.RexBuilder#makeCastIntervalToExact

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.17.0
• Component/s: core
• Assignee: Unassigned
• Reporter: Vladimir Sitnikov
• Created: 16/Sep/18 18:09
• Updated: 22/Feb/19 01:19

Description

    final int scale = 0;
    BigDecimal divider = endUnit.multiplier.scaleByPowerOfTen(-scale);
    RexNode value = multiplyDivide(decodeIntervalOrDecimal(exp),
        multiplier, divider);
    if (scale > 0) { // <-- THIS IS ALWAYS FALSE
      RelDataType decimalType =
          getTypeFactory().createSqlType(
              SqlTypeName.DECIMAL,
              scale + exp.getType().getPrecision(),
              scale);
      value = encodeIntervalOrDecimal(value, decimalType, false);
    }

Is if(scale>0) a dead code?