Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-1780

Add `required Order` and `requiresOver` parameters to the constructor of `SqlUserDefinedAggregate Function`

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.13.0
    • core
    • None

    Description

      Currently org.apache.calcite.sql.validate.SqlUserDefinedAggFunction calls the constructor of SqlAggFunction:

      Protected SqlAggFunction (
             String name,
             SqlIdentifier sqlIdentifier,
             SqlKind kind,
             SqlReturnTypeInference returnTypeInference,
             SqlOperandTypeInference operandTypeInference,
             SqlOperandTypeChecker operandTypeChecker,
             SqlFunctionCategory funcType,
             Boolean requiresOrder,
             Boolean requiresOver) 
      

      The requiresOrder = false, requiresOver = false. as follow:

      Public SqlUserDefinedAggFunction (SqlIdentifier opName,
             SqlReturnTypeInference returnTypeInference,
             SqlOperandTypeInference operandTypeInference,
             SqlOperandTypeChecker operandTypeChecker, AggregateFunction function) {
           Super (Util.last (opName.names), opName, SqlKind.OTHER_FUNCTION,
               ReturnTypeInference, operandTypeInference, operandTypeChecker,
               SqlFunctionCategory.USER_DEFINED_FUNCTION, false, false);
           This.function = function;
         } 
      

      I want add `required Order` and `requiresOver` parameters to the constructor of `SqlUserDefinedAggregate Function`.

      Attachments

        Activity

          People

            sunjincheng121 sunjincheng
            sunjincheng121 sunjincheng
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: