Issue Details (XML | Word | Printable)

Key: CACTUS-220
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Petar Tahchiev
Reporter: Natalia Kowalczyk
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Cactus

Integration with HtmlUnit

Created: 09/Jul/05 10:53 PM   Updated: 11/Apr/08 12:37 PM
Return to search
Component/s: None
Affects Version/s: 1.7
Fix Version/s: 1.8

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works patchHtmlunit.txt 2005-07-30 06:56 PM Nicolas Chalumeau 14 kB
Java Source File Licensed for inclusion in ASF works TestHtmlUnitIntegration.java 2005-07-27 05:15 PM Nicolas Chalumeau 3 kB
File Licensed for inclusion in ASF works WebResponseObjectFactory.diff 2005-07-09 10:55 PM Natalia Kowalczyk 3 kB

Resolution Date: 02/Mar/08 10:14 PM


 Description  « Hide
Cactus could integrate with HtmlUnit in the same fashion it does with HttpUnit. HtmlUnit recognizes more HTML object as scriptable and thus offers better JavaScript processing.
Attaching a patch for the WebResponseObjectFactory class.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Natalia Kowalczyk added a comment - 09/Jul/05 10:55 PM
CVS diff of WebResponseObjectFactory with a patch

Natalia Kowalczyk made changes - 09/Jul/05 10:55 PM
Field Original Value New Value
Attachment WebResponseObjectFactory.diff [ 12311157 ]
Vincent Massol added a comment - 10/Jul/05 02:20 AM
Thanks Natakia, that's a great patch. Do you think you could add some junit tests in samples/servlet that proves that it works? Also, it would be great if you could submit some doco patch (they're in documentation/docs/xdocs). Having all this will make is much faster to apply your patch as otherwise we'll need to write all those. Thanks again for this very useful patch!

Nicolas Chalumeau added a comment - 27/Jul/05 05:15 PM
Here is a test case for this issue. I also modify in differant location classpath/dependancies to make the build work and the test pass (it work on my system) but i can't attach the patch ATM as I am offline and can't make any diff so the patch arrive this weekend.

Nicolas Chalumeau made changes - 27/Jul/05 05:15 PM
Attachment TestHtmlUnitIntegration.java [ 12311415 ]
Nicolas Chalumeau added a comment - 30/Jul/05 06:56 PM
Here is the patch to add htmlunitjar in the differants classpath/dependancies

Nicolas Chalumeau made changes - 30/Jul/05 06:56 PM
Attachment patchHtmlunit.txt [ 12311466 ]
Nicolas Chalumeau made changes - 03/Aug/05 09:26 PM
Assignee Nicolas Chalumeau [ nchalumeau ]
Nicolas Chalumeau made changes - 04/Aug/05 08:51 PM
Status Open [ 1 ] In Progress [ 3 ]
Nicolas Chalumeau added a comment - 30/Sep/05 09:01 PM
I will commit the patch this week end

Nicolas Chalumeau made changes - 30/Sep/05 09:01 PM
Fix Version/s 1.8 [ 12310167 ]
Repository Revision Date User Message
ASF #293031 Sat Oct 01 22:00:33 UTC 2005 nchalumeau [CACTUS-220] add html unit integration
Files Changed
MODIFY /jakarta/cactus/trunk/framework/project.xml
MODIFY /jakarta/cactus/trunk/download.xml
MODIFY /jakarta/cactus/trunk/integration/ant/src/scripts/share/build-share.xml
MODIFY /jakarta/cactus/trunk/integration/maven/plugin.jelly
MODIFY /jakarta/cactus/trunk/samples/servlet/src/scripts/share/build.xml
MODIFY /jakarta/cactus/trunk/framework/build.xml
MODIFY /jakarta/cactus/trunk/build.xml
MODIFY /jakarta/cactus/trunk/samples/servlet/build.xml
MODIFY /jakarta/cactus/trunk/dependencies.xml.default
MODIFY /jakarta/cactus/trunk/build.properties.default
ADD /jakarta/cactus/trunk/samples/servlet/src/test-cactus/share/org/apache/cactus/sample/servlet/unit/TestHtmlUnitIntegration.java
MODIFY /jakarta/cactus/trunk/.project
MODIFY /jakarta/cactus/trunk/framework/src/java/share-12-13-14/org/apache/cactus/internal/client/WebResponseObjectFactory.java

Felipe Leme made changes - 07/Jan/06 10:37 AM
Assignee Nicolas Chalumeau [ nchalumeau ]
Repository Revision Date User Message
ASF #369213 Sun Jan 15 15:24:01 UTC 2006 felipeal CACTUS-220: added htmlunit info
Files Changed
MODIFY /jakarta/cactus/trunk/documentation/licenses/README.txt
ADD /jakarta/cactus/trunk/documentation/licenses/htmlunit.txt

Felipe Leme added a comment - 16/Jan/06 12:16 AM
While I was testing Cactus's samples, I got this error testing on Tomcat 5:

[cactustests] Null Test: Caused an ERROR
[cactustests] com/gargoylesoftware/htmlunit/WebResponse
[cactustests] java.lang.NoClassDefFoundError: com/gargoylesoftware/htmlunit/WebResponse
[cactustests] at java.lang.Class.getDeclaredMethods0(Native Method)
[cactustests] at java.lang.Class.privateGetDeclaredMethods(Class.java:2365)
[cactustests] at java.lang.Class.getMethod0(Class.java:2611)
[cactustests] at java.lang.Class.getMethod(Class.java:1579)

It probably means we didn't bundle a jar needed by HTML Unit...



Felipe Leme added a comment - 16/Jan/06 12:23 AM
Nope, that class has no external dependency; looks like a classloader issue then...

Petar Tahchiev added a comment - 02/Mar/08 10:14 PM
Already integrated in the SVN HEAD. We will have to think of a better integration for the future. I am closing this issue now and will open one after we release Cactus 1.8.

Petar Tahchiev made changes - 02/Mar/08 10:14 PM
Resolution Fixed [ 1 ]
Status In Progress [ 3 ] Resolved [ 5 ]
Assignee Petar Tahchiev [ paranoiabla ]
Petar Tahchiev made changes - 11/Apr/08 12:37 PM
Status Resolved [ 5 ] Closed [ 6 ]