|
[
Permlink
| « Hide
]
Markus Cozowicz added a comment - 04/Nov/04 03:45 PM
That stuff should be refactored
Thanks Marcus. We're currently refactoring the Ant integration to use Cargo (http://cargo.codehaus.org) and in the near future all the container logic will be in Cargo. Your patch will not be lost as we'll be able to use it to implement JBoss 4.x support for Cargo. If you wish to participate to cargo please join us on the Cargo mailing list.
Thanks -Vincent Changed component and version.
Please include this patch in the following release.
At least this patch enables people to already start using Cactus with JBoss 4 instead of waiting for this Cargo refactoring to be finished... I agree with Wonne that it should be incorporated before the Cargo integration, but as the patch poster said, it needs some refactoring: right now it's just a copy & paste of the JBoss 3 code.
I started such refactoring a couple of nights ago, but haven't had the time to finish it out (and unfortunately won't be able to continue in the next days). Basically, I created a new AbstractJBossContainer class and tried to move most of the common code there, using the Template Pattern in some methods. -- Felipe I was planning to fix this bug as is, i.e., without refactoring the code, but then I realize that are too many things that must be changed, as JBoss 4.0 is a J2EE 1.4 server (and 3.x was 1.3).
So, we better leave it to the Cargo integration on Cactus 1.8... Already fixed in Cactus SVN HEAD. I am closing this issue.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||