[PATCH] cactus can't shutdown JBoss 3.0.8

• Key: CACTUS-122
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Vincent Massol
• Reporter: Raphael Philipe Mendes da Silva
• Component/s: Ant Integration
• Affects Version/s: 1.6.1
• Fix Version/s: 1.7

Environment

Operating System: windows 2000 SP4
J2sdk1.4.3_04
jboss-3.0.8_tomcat-4.1.24
maven-1.0-rc3

Description

In our company we use maven as project manager tool(build, tests, site generation). Recently, when we update the maven-cactus-plugin from the version 1.6dev to 1.6.1 we find some problems: An unexpected error happens when cactus tries to shutdown JBoss.
This is the stdout generated:
cactus:test-war:
    [cactus] -----------------------------------------------------------------
    [cactus] Running tests against JBoss 3.0.8
    [cactus] -----------------------------------------------------------------
    [cactus] Running com.cpqd.util.configuration.TestConfigurationContextPersistency
    [cactus] log4j:WARN No appenders could be found for logger (org.apache.cactus.internal.server.ServerTestCaseCaller).
    [cactus] log4j:WARN Please initialize the log4j system properly.
    [cactus] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 5.141 sec
    [cactus] Testsuite: com.cpqd.util.configuration.TestConfigurationContextPersistency
    [cactus] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 5.141 sec
    [cactus]
    [cactus] Testcase: testRetryManyConnection took 2.609 sec
    [cactus] Testcase: testSequence took 0.594 sec
    [cactus] Testcase: testSequenceWithListener took 0.672 sec
    [cactus] Testcase: testSearch took 0.609 sec
    [cactus] java.lang.NumberFormatException: For input string: "localhost"
    [cactus] at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
    [cactus] at java.lang.Integer.parseInt(Integer.java:468)
    [cactus] at java.lang.Integer.parseInt(Integer.java:518)
    [cactus] at org.jboss.Shutdown.main(Shutdown.java:75)
    [cactus] Exception in thread "main"
    [cactus] [ERROR] Java Result: 1


Loking for the code of the cactus, we have changed the method Shutdown of the class org.apache.cactus.integration.ant.container.jboss.JBoss3xContainer(see patch attached).
We already tested on Jboss 3.0.8 and it worked. We will test on Jboss 3.2.3 once we finish downloading it.