Tomcat Pageflow Adapter does not compile with Tomcat 5.5.x

• Key: BEEHIVE-634
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Julie Zhuo
• Reporter: Abdessattar Sassi
• Component/s: NetUI
• Affects Version/s: V1Alpha, V1Beta, v1m1
• Fix Version/s: 1.0.1

Description

The compilation of module tomcat-server under netui fails due to the use of obsolete Tomcat internal classes and interfaces.


build:
     [echo] compile module: tomcat-server
     [echo] module classpath: D:\J2EE\beehive-src\trunk\external\servlet\servlet-api-2.4.jar;D:\J2EE\beehive-src\trunk\external\servlet\jsp-
api-2.0.jar;D:\J2EE\beehive-src\trunk\external\log4j\log4j-1.2.8.jar;D:\J2EE\beehive-src\trunk\external\commons\commons-logging-1.0.4.jar;D:
\J2EE\beehive-src\trunk\netui\build\lib\beehive-netui-tomcat-common-5x.jar;D:\J2EE\beehive-src\trunk\netui\external\tomcat\5x\catalina.jar;D
:\J2EE\beehive-src\trunk\netui\external\tomcat\5x\tomcat-coyote.jar
     [echo] debug: true
    [javac] Compiling 2 source files to D:\J2EE\beehive-src\trunk\netui\build\classes\tomcat-server
    [javac] D:\J2EE\beehive-src\trunk\netui\src\tomcat-server\5x\org\apache\beehive\netui\tomcat\PageflowHelperImpl.java:24: package org.apa
che.coyote.tomcat5 does not exist
    [javac] import org.apache.coyote.tomcat5.CoyoteConnector;
    [javac] ^
    [javac] D:\J2EE\beehive-src\trunk\netui\src\tomcat-server\5x\org\apache\beehive\netui\tomcat\PageflowHelperImpl.java:35: cannot find sym
bol
    [javac] symbol : class HttpRequest
    [javac] location: class org.apache.beehive.netui.tomcat.PageflowHelperImpl
    [javac] private HttpRequest _request = null;
    [javac] ^
    [javac] D:\J2EE\beehive-src\trunk\netui\src\tomcat-server\5x\org\apache\beehive\netui\tomcat\PageflowHelperImpl.java:36: cannot find sym
bol
    [javac] symbol : class HttpResponse
    [javac] location: class org.apache.beehive.netui.tomcat.PageflowHelperImpl
    [javac] private HttpResponse _response = null;
    [javac] ^
    [javac] D:\J2EE\beehive-src\trunk\netui\src\tomcat-server\5x\org\apache\beehive\netui\tomcat\PageflowHelperImpl.java:271: cannot find sy
mbol
    [javac] symbol : class HttpRequest
    [javac] location: class org.apache.beehive.netui.tomcat.PageflowHelperImpl
    [javac] void initRequest( HttpRequest request, HttpResponse response, PageflowValve valve )
    [javac] ^
    [javac] D:\J2EE\beehive-src\trunk\netui\src\tomcat-server\5x\org\apache\beehive\netui\tomcat\PageflowHelperImpl.java:271: cannot find sy
mbol
    [javac] symbol : class HttpResponse
    [javac] location: class org.apache.beehive.netui.tomcat.PageflowHelperImpl
    [javac] void initRequest( HttpRequest request, HttpResponse response, PageflowValve valve )
    [javac] ^
    [javac] D:\J2EE\beehive-src\trunk\netui\src\tomcat-server\5x\org\apache\beehive\netui\tomcat\PageflowValve.java:41: cannot find symbol
    [javac] symbol : class Request
    [javac] location: class org.apache.beehive.netui.tomcat.PageflowValve
    [javac] public void invoke(Request request, Response response, ValveContext valveContext)

....

Comments

[Eddie O'Neil]

We should probably fix that at some point. :)

We're currently not shipping the Tomcat server adapter in the Beehive distribution and aren't planning to for 1.0, which we're working toward now. Given this, I'm going to start the bug to be fixed in TBD.

Feel free to provide a patch for this! We'd probably need to create a:

  src/tomcat-server/5.5/

directory structure and add the 5.5 libraries to:

  netui/external

Thanks for filing the issue!

[Abdessattar Sassi]

Attached in patch.txt is a SVN patch file to add the necessary code and fixes for the Tomcat adapter to work with Tomcat 5.5.7 or later.
Note that the patch requires that the catalina.jar and tomcat-coyote.jar in netui/external/tomcat/5x be updated from tomcat 5.5.7 at least (preferably 5.5.9).

[Abdessattar Sassi]

Also see BEEHIVE-635 http://issues.apache.org/jira/browse/BEEHIVE-635

[Rich Feit]

Abdessattar,

Thank you for the code update! And sorry for the late response -- I was away when you filed this. The one thing that needs to happen is along the lines of what Eddie suggested: putting this somewhere 5.5-related, without removing our 5.0.x support. I'll work on that as soon as I can.

Great to have this contributed; thanks again.

[Rich Feit]

Will get this in ASAP after we get 1.0 out the door.

[Rich Feit]

This is in with revision 328795. Abdessattar, thank you for the patch, and sorry for the long delay.

(I modified this to leave the 5.0.x one in the tree, with this new one as a peer.)

Alex, I put in a README.txt in netui/test/webapps/tomcat for running the tests against both 5.0.x and 5.5.x.

[Julie Zhuo]

Verified with rev374070. Now we create different version of Adapters, 5.0.x znc 5.5.x. They both compiled successfully with both tomcat5.0.28 and tomcat5.5.9. Close.