[BEAM-5804] Remove JavaCC bad option warning

• Type: Improvement
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Fix Version/s: Not applicable
• Component/s: dsl-sql
• Assignee: Michael Luckey
• Reporter: Michael Luckey
• Created: 20/Oct/18 10:13
• Updated: 24/Jul/20 19:51
• Resolved: 10/Feb/19 00:00

Description

After the downgrade to JavaCC 4.0 [1], JavaCC compiler issues a warning

{no format}

$ ./gradlew -p sdks/java/extensions/sql cleanCompileJavacc compileJavacc 

> Task :beam-sdks-java-extensions-sql:compileJavacc

Java Compiler Compiler Version 4.0 (Parser Generator)

(type "javacc" with no arguments for help)

Warning: Bad option "-grammar_encoding=UTF-8" will be ignored.
{no format}

This is simply due to the fact, that this option does not yet exist in JavaCC 4.0 [2]

 

So we probably should just remove this option.

[1] https://issues.apache.org/jira/browse/BEAM-4233

[2] https://github.com/javacc/javacc/blob/368da68784dca6b29dcf10043f056535b2c835a1/src/org/javacc/parser/Options.java#L93-L117

Issue Links

• links to: GitHub Pull Request #6768