[BEAM-5742] Add expectations for code reviews

• Type: Sub-task
• Status: Resolved
• Priority: P3
• Resolution: Won't Fix
• Fix Version/s: Not applicable
• Component/s: website
• Assignee: Unassigned
• Reporter: Scott Wegner
• Created: 12/Oct/18 22:42
• Updated: 15/Mar/22 15:23
• Resolved: 15/Mar/22 15:23

Description

There should be a dedicated section about how we to code reviews, and expectations for contributors / reviewers. Things like:

• PR's should have linked JIRA
• Code changes should also include tests
• Small changes are easier to review
• How to find a reviewer, when you can expect reviewer to engage
• How automatic test runs work (PreCommits run by on each commit; build / test should be passing before asking for a reviewer)
• How to re-run tests, and how/when to run Post-Commits