[BEAM-2482] CodedValueMutationDetector should use the coders structural value

• Type: Improvement
• Status: Resolved
• Priority: P3
• Resolution: Fixed
• Fix Version/s: 2.3.0
• Component/s: runner-direct
• Labels: newbie starter
• Assignee: Innocent
• Reporter: Luke Cwik
• Created: 20/Jun/17 15:52
• Updated: 16/May/20 13:18
• Resolved: 01/Nov/17 17:44

Description

Currently the CodedValueMutationDetector[1] checks to see if the objects are Java equals and then compares whether the bytes are equal. Instead of relying on the bytes, we should rely on the coders structural value explicitly[2]. This allows for a coder to provide a fast path equality check with the default still comparing byte array representations.

1: https://github.com/apache/beam/blob/eae0d05bd7c088accd927dcfe3e511efbb11c9fd/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MutationDetectors.java
2: https://github.com/apache/beam/blob/01b3f87f977d44eac23eb5488074bbc638858a9d/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java#L252

Issue Links

• links to: GitHub Pull Request #3406