[BEAM-1988] utils.path.join does not correctly handle GCS bucket roots

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: sdk-py-core
• Assignee: Sourabh Bajaj
• Reporter: Ahmet Altay
• Created: 17/Apr/17 23:49
• Updated: 16/May/20 13:40
• Resolved: 25/Apr/17 21:39

Description

Here:
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/path.py#L22

Joining a bucket root with a filename e.g. (gs://mybucket/ , myfile) results in invalid 'gs://mybucket//myfile', notice the double // between mybucket and myfile. (It actually does not handle anything that already ends with / correctly)

sb2nov could you take this one? Also, should the `join` operation move to a BeamFileSystem level code.

(cc: chamikara)

Issue Links

• links to: GitHub Pull Request #2585
• links to: GitHub Pull Request #2643
• links to: GitHub Pull Request #2665