Uploaded image for project: 'Commons BCEL'
  1. Commons BCEL
  2. BCEL-186

Performance degradation with the UTF8 cache

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 6.0
    • 6.0
    • None
    • None
    • blocker

    Description

      I'd love to see 6.0 released.

      Here was the last vote:
      http://apache-commons.680414.n4.nabble.com/VOTE-Release-BCEL-6-0-based-on-RC3-td4667129.html

      Konstantin Kolinko reported some issues with caching that blocked the release:

      I noted new methods that introduced caching into classfile.ConstantUtf8 class. BCEL_DONT_CACHE should at least have static setter, or a static setter for a cache instance / a factory class. RELEASE-NOTES.txt describes this change as BCEL-163 Incorporate patch file from Findbugs which does not say much about this change. Actually this change introduced caching for ConstantUtf8 and ObjectType instances.

      Emmanuel Bourg did some investigation and testing and reported back:

      If nobody object I'll remove this cache, the impact on the performance is too important to enable it by default, and the static state smells like a quick and dirty implementation. This feature could return as a pluggable cache if someone wants to provide a patch.

      garydgregory suggested adding a flush method to clear the cache in ObjectType

      Attachments

        1. patch2.diff
          4 kB
          Java Developer
        2. revert-ConstantUtf8-cache.diff
          4 kB
          Java Developer

        Activity

          People

            Unassigned Unassigned
            chengas123 Java Developer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: