[BCEL-141] Select instructions should implement StackConsumer instead of StackProducer

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 5.2
• Fix Version/s: 6.0
• Component/s: Main
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=48908
• Severity: minor
• Priority: P2
• External issue ID: 48908
• Assignee: Apache Commons Developers
• Reporter: hobbbo
• Created: 14/Mar/10 12:52
• Updated: 14/Jul/16 12:48
• Resolved: 13/Mar/11 14:41

Description

Select instruction (class org.apache.bcel.generic.Select) is currently implementing interface StackProducer. It should instead, implement interface StackConsumer, since both instructions LOOKUPSWITCH and TABLESWITCH do consume (pop) the operand stack. In addition calls to produceStack() and consumeStack() do return the correct value.