[BCEL-140] org.apache.bcel.generic.Instruction.equals(Object) does not follow Object.equals(Object) rules

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 5.2
• Fix Version/s: 6.0
• Component/s: Main
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=48321
• Severity: normal
• Priority: P2
• External issue ID: 48321
• Assignee: Apache Commons Developers
• Reporter: Vít Šesták aka v6ak
• Created: 01/Dec/09 08:18
• Updated: 14/Jul/16 12:48
• Resolved: 13/Mar/11 14:45

Description

org.apache.bcel.generic.Instruction contains two strange methods: equals and setComparator. The equals and hashCode methods are by definition (see http://java.sun.com/javase/6/docs/api/java/lang/Object.html#hashCode%28%29 ) broken:

• If two Instruction objects have another InstructionComparator, they can be asymmetrically equal.
• If instructions aren't compared by identity (==), the inherited hashCode method is by definition broken.

I suggest: deprecate setComparator method.