[AVRO-520] Refactor validation code

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: c++
• Assignee: Unassigned
• Reporter: Scott Banachowski
• Created: 17/Apr/10 23:05
• Updated: 11/May/10 14:54
• Resolved: 18/Apr/10 17:19

Description

This patch reorganizes some of the code around the validator.

The previous version uses different classes for Writer and ValidatingWriter, and Reader and ValidatingReader.

These types have been redefined respectively as WriterImpl<NullValidator> and WriterImpl<Validator>, and ReaderImpl<NullValidator> and ReaderImpl<Validator>. The compiler generates 4 types, but the NullValidator compiles away as no-ops, creating essentially the same classes as before. This allows logic to exist in single class definitions instead of duplicates.

Also, in the Validator some special logic was removed for records, now instead sharing code with the other compound types.