[AVRO-2757] ReflectData still generates namespaces with dollar signs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.11.0
• Component/s: java
• Assignee: Ryan Skraba
• Reporter: Ryan Skraba
• Created: 21/Feb/20 10:44
• Updated: 09/Nov/20 14:35
• Resolved: 02/Jul/20 12:20

Description

ReflectData should always generate valid Avro schemas for Java classes.  Currently, the name and namespace are taken from the Java class name, which can contain dollar signs.  AVRO-2143 fixed this for the most common cases for nested classes.

It's still possible to generate namespaces with a dollar sign for classes that are nested more than one level.  This can be observed in this unit test:

https://github.com/apache/avro/blob/70260919426f89825ca148f5ee815f3b2cf4764d/lang/java/avro/src/test/java/org/apache/avro/reflect/TestReflect.java#L842

which generates

{
  "type" : "record",
  "name" : "AnotherSampleRecord",
  "namespace" : "org.apache.avro.reflect.TestReflect$SampleRecord",
  "fields" : [ {
    "name" : "a",
    "type" : [ "null", "int" ],
    "default" : null
  }, {
    "name" : "s",
    "type" : [ "null", {
      "type" : "record",
      "name" : "SampleRecord",
      "namespace" : "org.apache.avro.reflect.TestReflect",
      "fields" : [ {
        "name" : "x",
        "type" : "int"
      }, {
        "name" : "y",
        "type" : "int"
      } ]
    } ],
    "default" : null
  } ]
}

 

Issue Links

• is related to: AVRO-2659 [JAVA] Some full names are not correctly validated.
• is related to: AVRO-2143 ReflectData should determine inner class names in a different way.
• relates to: AVRO-2956 SpecificRecord decoding fails if Java keyword is used as record name