[AVRO-2499] C# reflect does not cache classes referenced in a union

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Component/s: csharp
• Assignee: Patrick Farry
• Reporter: Patrick Farry
• Created: 05/Aug/19 21:42
• Updated: 02/Jul/20 12:22
• Resolved: 26/May/20 13:58

Description

In the example below an attempt to serialize an object of type A fails.

{ "name" : "A", 

   "type" " : "record",

   "fields" : [

        { "name" : "OptionalProperty",

           "type" : [ "null",

                         

{ "name" : "B",                              "type" : "record",                              "fields" : [ "name" : "C", "type" : "string" ]                            }

                      ]

        }

} 

 

 

 

C# classes

public class A

{     public B OptionalProperty \{ get; set;}

}

public class B

{     public string C \{ get; set;}

}

 

 

Problem is in Reflect/ClassCache.cs line 259.

Need to add the following case
case UnionSchema us:
    foreach (var o in us.Schemas)
    {
        if (o.Tag!=Avro.Schema.Type.Null)
       

{             LoadClassCache(objType, o);         }

    }
 
Will do a PR 

Issue Links

• links to: GitHub Pull Request #617
• links to: GitHub Pull Request #652