[AVRO-2337] Possibility of NPE in SchemaCompatibility

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.9.0, 1.8.2
• Component/s: java
• Assignee: Unassigned
• Reporter: David Mollitor
• Created: 06/Mar/19 23:58
• Updated: 19/Jul/23 13:19

Description

final Field writerField = lookupWriterField(writer, readerField);

// ---- following block is only entered if writerField is 'null'
if (writerField == null) {
  if (readerField.defaultValue() == null) {
    if (readerField.schema().getType() == Type.ENUM && readerField.schema().getEnumDefault() != null) {

       // ---- writerField is accessed
      result = result.mergedWith(getCompatibility("type", readerField.schema(),
        writerField.schema(), location));
    } else {
...

https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/SchemaCompatibility.java#L417
 
https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/SchemaCompatibility.java#L424