[AVRO-2061] Improve Invalid File Format Error Message

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.9.0, 1.8.2
• Fix Version/s: 1.9.0
• Component/s: java
• Hadoop Flags: Incompatible change
• Release Note: Changed the message of the IOException thrown in case of a non avro file is passed for parsing.
• Flags: Patch
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 03/Aug/17 20:28
• Updated: 14/Aug/17 09:32
• Resolved: 14/Aug/17 09:32

Description

org.apache.avro.file.DataFileStream<D>

    try {
      vin.readFixed(magic);                         // read magic
    } catch (IOException e) {
      throw new IOException("Not a data file.", e);
    }
    if (!Arrays.equals(DataFileConstants.MAGIC, magic))
      throw new IOException("Not a data file.");

Please consider improving the error message here. I just saw a MapReduce job fail with an IOException with the message "Not a data file." There was definitely data files in the input directory, however, they were not Avro files. It would have been much more helpful if it told me that.