[AVRO-2052] Remove org.apache.avro.file.DataFileWriter Double Buffering

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Not A Problem
• Affects Version/s: 1.7.7, 1.8.2
• Component/s: java
• Flags: Patch
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 17/Jul/17 23:02
• Updated: 22/Jul/17 15:04
• Resolved: 22/Jul/17 15:04

Description

org.apache.avro.file.DataFileWriter

  private void init(OutputStream outs) throws IOException {
    this.underlyingStream = outs;
    this.out = new BufferedFileOutputStream(outs);
    EncoderFactory efactory = new EncoderFactory();
    this.vout = efactory.binaryEncoder(out, null);
    dout.setSchema(schema);
    buffer = new NonCopyingByteArrayOutputStream(
        Math.min((int)(syncInterval * 1.25), Integer.MAX_VALUE/2 -1));
    this.bufOut = efactory.binaryEncoder(buffer, null);
    if (this.codec == null) {
      this.codec = CodecFactory.nullCodec().createInstance();
    }
    this.isOpen = true;
  }

It's clear here that both streams are writing to a buffered destination, {{ BufferedFileOutputStream}} and ByteArrayOutputStream therefore there is no reason to need a buffered encoder and instead, write directly to the buffered streams with directBinaryEncoder.