[AVRO-1989] Ruby schema validation for fixed types should use bytesize in error message

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.0
• Fix Version/s: 1.9.0
• Component/s: ruby
• Assignee: Fokko Driesprong
• Reporter: Sean Busbey
• Created: 28/Jan/17 06:11
• Updated: 12/Feb/19 16:47
• Resolved: 12/Feb/19 15:55

Description

From AVRO-1886:

I'd like to get one thing improved, but it's fine as a follow-on.

 +       when :fixed
 +          if datum.is_a? String
 +            message = "expected fixed with size #{expected_schema.size}, got \"#{datum}\" with size #{datum.size}"
 +            result.add_error(path, message) unless datum.bytesize == expected_schema.size
 +          else
 +            result.add_error(path, "expected fixed with size #{expected_schema.size}, got #{actual_value_message(datum)}")
 +          end

the message here should use datum.bytesize instead of datum.size.

Issue Links

• is broken by: AVRO-1886 Improve error reporting for schema validation
• links to: GitHub Pull Request #451