[AVRO-1818] Avoid buffer copy in DeflateCodec.compress and decompress

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: java
• Assignee: Nándor Kollár
• Reporter: Rohini Palaniswamy
• Created: 31/Mar/16 21:39
• Updated: 30/Dec/18 04:17

Description

One of our jobs reading avro hit OOM due to the buffer copy in compress and decompress methods which is very inefficient.

https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/file/DeflateCodec.java#L71-L86

java.lang.OutOfMemoryError: Java heap space
	at java.util.Arrays.copyOf(Arrays.java:3236)
	at java.io.ByteArrayOutputStream.toByteArray(ByteArrayOutputStream.java:191)
	at org.apache.avro.file.DeflateCodec.decompress(DeflateCodec.java:84)

I would suggest using a class that extends ByteArrrayOutputStream like https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/DataOutputBuffer.java#L51-L53

and do
ByteBuffer result = ByteBuffer.wrap(buf.getData(), 0, buf.getLength());

Issue Links

• links to: GitHub Pull Request #152