[AVRO-1742] Avro C# DataFileWriter Flush() does not flush the buffer to disk

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: csharp
• Assignee: Unassigned
• Reporter: Mika Ristimaki
• Created: 23/Sep/15 13:10
• Updated: 30/Dec/18 04:22

Description

In C# DataFileWriter.Flush() is implemented as

public void Flush()
        {
            EnsureHeader();
            Sync();
        }

Is this by Avro spec or is this a bug. So should calling DataFileWriter.Flush() just start a new Sync block and not flush the file to disc?

In Java the implementation is

 @Override
  public void flush() throws IOException {
    sync();
    vout.flush();
  }

where vout is a BinaryEncoder. So I think the correct implementation in C# is

public void Flush()
        {
            EnsureHeader();
            Sync();
           _encoder.Flush()
        }

If someone can confirm my suspicion I'll try to contribute a fix in the near future.