[AVRO-1607] Minor performance enhancement

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.8.0
• Component/s: java
• Assignee: Unassigned
• Reporter: Zoltan Farkas
• Created: 18/Nov/14 16:22
• Updated: 06/May/20 13:19

Description

In SpecificData.getClass, line 164:

    case UNION:
      List<Schema> types = schema.getTypes();     // elide unions with null
      if ((types.size() == 2) && types.contains(NULL_SCHEMA))
        return getWrapper(types.get(types.get(0).equals(NULL_SCHEMA) ? 1 : 0));
      return Object.class;

can be written more efficiently as:

    case UNION:
      List<Schema> types = schema.getTypes();     // elide unions with null
      if ((types.size() == 2)) {
        if (NULL_SCHEMA.equals(types.get(0))) {
          return getWrapper(types.get(1));
        } else if (NULL_SCHEMA.equals(types.get(1))) {
           return getWrapper(types.get(0));
        }
      }
      return Object.class;