[AVRO-1168] IDL Tool - Field properties are added against schema instead of field

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: 1.7.1
• Component/s: java

Release Note

Actually I realized you can annotate both the field schema and the field itself.

string @Prop field

Strange, but it works, so closing

• Assignee: Unassigned
• Reporter: Cristian Opris
• Created: 18/Sep/12 16:34
• Updated: 25/Sep/12 21:22
• Resolved: 18/Sep/12 16:57

Description

In Idl.jj, field properties are added against the field schema instead of the field, resulting in an error if different fields of the same record
type are annotated with the same property name.

Example:
<code>
record RecordA {
}

record RecordB {
@Prop("")
RecordA a1

@Prop("")
RecordA a2
}
</code>

Note this fails even if a1 and a2 are in different records (since the Schema instance is shared)

Proposed fix: - change Idl.jj to add props agains the fields props, not the schema:

<code>
for (String key : props.keySet())
type.addProp(key, getTextProp(key, props, token));
</code>

should read:
<code>
field.addProp(...)
</code>