[attributes] Ability to add attributepackages in maven

• Key: ATTRIBUTES-4
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Gerald Benischke
• Affects Version/s: 2.1
• Fix Version/s: 2.2

Environment

Operating System: other
Platform: Other

Description

When the ant:attribute-compiler is used in ant, there is no way for maven to
pass a value for the attributepackages property.

It would be nice if it were possible to add a property in the project.properties
of the current project that specifies the attributepackages. E.g.

project.properties:
[...]
org.apache.commons.attributes.packages=my.package
[...]

which is then used in the maven plugin:

[...]
<ant:attribute-compiler inMaven="true" sourcepathref="maven.compile.src.set"
attributepackages="${org.apache.commons.attributes.packages}"
destdir="${maven.build.dir}/commons-attributes"/>
[...]

Comments

[leo.sutic]

Oh God. I hope you haven't given up on C-A due to my one-year leave from the
project. If you did, then I guess that'll teach me to check bugzilla bit more
often. If not, then:

I think that's a great idea (and easily implementable as well ) and I'm
surprised I didn't implement it myself. I'll roll that into the 2.2 release
that I should get out the door soon-ish.

/LS

[Sebastián Fiorentini]

Just insert this line (at line 76)

attributepackages="${org.apache.commons.attributes.attributepackages}"

to the plugin/plugin.jelly.

Regards,Sebastian.

[Flier Lu]

All the goals (commons-attributes:compile and commons-attributes:test-compile)
need this attribute. thanks