[ATLAS-1014] Unnecessary locking and double checked locking for a threadlocal in RequestContext.

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Done
• Assignee: Unassigned
• Reporter: Satish Duggana
• Created: 12/Jul/16 16:11
• Updated: 18/May/20 04:40
• Resolved: 18/May/20 04:40

Description

    public static RequestContext get() {
        if (CURRENT_CONTEXT.get() == null) {
            synchronized (RequestContext.class) {
                if (CURRENT_CONTEXT.get() == null) {
                    createContext();
                }
            }
        }
        return CURRENT_CONTEXT.get();
    }

There is no need to have double checked locking and synchronization for setting a threadlocal state. That logic can be removed by adding the below code while instantiating CURRENT_CONTEXT.

    private static final ThreadLocal<RequestContext> CURRENT_CONTEXT = new ThreadLocal<RequestContext>() {
        @Override
        protected RequestContext initialValue() {
            RequestContext context = new RequestContext();
            context.requestTime = System.currentTimeMillis();
            return context;
        }
    };

RequestContext#createContext usages can be changed to RequestContext#get