[ARROW-4664] [C++] DCHECK macro conditions are evaluated in release builds

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: C++
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/21195
• Assignee: Wes McKinney
• Reporter: Ben Kietzman
• Created: 22/Feb/19 16:07
• Updated: 11/Jan/23 07:35
• Resolved: 12/Mar/19 16:23

Description

DCHECK(potentially_expensive()) will evaluate the argument even in release mode, and is used in several places with the assumption that it will do so (which means removing the guarantee of evaluation causes numerous failures). By contrast, most debug assertion macros elide their arguments entirely (<cassert>.assert, <glog/logging.h>) in release mode

Issue Links

• links to: GitHub Pull Request #3854