[ARROW-3227] [Python] NativeFile.write shouldn't accept unicode strings

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10.0
• Fix Version/s: 0.11.0
• Component/s: Python
• Labels: pull-request-available
• External issue URL: https://github.com/apache/arrow/issues/19571
• Assignee: Wes McKinney
• Reporter: Antoine Pitrou
• Created: 12/Sep/18 19:12
• Updated: 11/Jan/23 07:26
• Resolved: 17/Sep/18 16:11

Description

Arrow files are binary, but for some reason NativeFile.write silently converts unicode strings to bytes.

>>> b = io.BytesIO()
>>> b.write("foo")
Traceback (most recent call last):
  File "<ipython-input-6-a7195dbc0372>", line 1, in <module>
    b.write("foo")

TypeError: a bytes-like object is required, not 'str'
>>> f = pa.PythonFile(b)
>>> f.write("foo")
>>> b.getvalue()
b'foo'
>>> f.write("😀")
>>> b.getvalue()
b'foo\xf0\x9f\x98\x80'

Issue Links

• links to: GitHub Pull Request #2570