Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-675

WrappingIterator's seenSeek should be protected

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 1.4.0, 1.4.1
    • 1.4.2, 1.5.0
    • tserver
    • None
    • OSX, Linux

    Description

      In 1.3, the WrappingIterator was pretty much some boilerplate code. In 1.4 on, a package private boolean called seenSeek was added to help enforce the iterator contract.

      This causes some issues with iterators written for 1.3 and before, because the seenSeek property can't be set by an iterator outside of the core.iterators package, which is locked down. This means that sub iterators must always delegate up to the WrappingIterator's seek() method, even if implementors want to completely override seek().

      I would like to provide more documentation on the WrappingIterator and make the seenSeek property protected so implementors don't need conditional logic to make the call to super.seek().

      Attachments

        1. wrapping-iterator-mod.patch
          1 kB
          William Slacum

        Activity

          People

            bills William Slacum
            bills William Slacum
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1m
                1m
                Remaining:
                Remaining Estimate - 1m
                1m
                Logged:
                Time Spent - Not Specified
                Not Specified