[ACCUMULO-4847] Fix Retry API

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.7.4, 1.9.0
• Component/s: fate
• Labels: pull-request-available
• Assignee: Christopher Tubbs
• Reporter: Christopher Tubbs
• Created: 14/Mar/18 17:02
• Updated: 23/Apr/19 16:13
• Resolved: 14/Mar/18 20:46

Description

ACCUMULO-4834 exposed a merge bug from ACCUMULO-4777. ACCUMULO-4777 added a parameter to the two Retry constructors, but since all the parameters are longs, this masked what should have been a compile failure by causing calls to the longer constructor to now use the shorter one.

The side effect is that any calls with "unlimited number of retries", would now be interpreted as "unlimited wait time between retries"... causing the first failure to sleep for Long.MAX_LONG millis before retrying.

I propose a refactor with a builder so the parameters cannot be confused for one another, since they all have the same long type. This is internal code, so there is no public API change.

Issue Links

• is caused by: ACCUMULO-4777 Root tablet got spammed with 1.8 million log entries
• relates to: ACCUMULO-4834 LocatorIT has no timeout and frequently hangs
• links to: GitHub Pull Request #399