[ACCUMULO-4584] Determine need for oneway method handling in RpcWrapper

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: rpc
• Assignee: Christopher Tubbs
• Reporter: Christopher Tubbs
• Created: 10/Feb/17 04:08
• Updated: 22/Feb/17 20:19
• Resolved: 22/Feb/17 20:19

Description

RpcWrapper has checks for oneway methods (from ACCUMULO-4065), but may no longer need it after upgrading to Thrift 0.10.0, due to the fix in THRIFT-3479

Should determine whether these are still needed or can be removed.

The current RpcWrapperTest fails if the checks are removed, but that test code may be assuming behavior in thrift, since it doesn't seem to actually use thrift code in the test itself.

Issue Links

• relates to: ACCUMULO-4065 Oneway Thrift calls leave message on client's InputStream
• relates to: THRIFT-3479 Oneway calls should not return exceptions to clients
• relates to: ACCUMULO-4551 Update to thrift-0.10.0
• links to: GitHub Pull Request #219