[ACCUMULO-3988] License / notice errors

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.5.4
• Component/s: build
• Assignee: Josh Elser
• Reporter: Sean Busbey
• Created: 10/Sep/15 06:45
• Updated: 20/Sep/15 15:09
• Resolved: 15/Sep/15 21:45

Description

latest 1.5.4 RC contains licensing errors. these might also be present in newer versions.

• test/src/test/java/org/apache/accumulo/test/DeleteRowsTest.java has a botched license header

source tarball

• LICENSE refs bundled works that are not present: jline
• LICENSE incorrectly cites bundled work: jquery and flot (no copyright, no text of license), bloom filters (no copyright, no text of license)
• LICENSE misses some bundled works:
  • sizzle.js (see jquery.js file header)
• NOTICE refs bundled works that are not present: jcommander
• NOTICE misses some bundled works:
  • Hadoop (see note in Value.java. Hadoop's NOTICE file isn't properly formed, so could skip)
  • Thrift (see note in TNonblockingServerSocket. Thrift 0.9 has a NOTICE file.)

bin

• problems with missing references still exist
• missing Thrift entry in NOTICE file expands from one file to java libthrift
• nit: JCommander should say that it's ASLv2 licensed
• LICENSE and NOTICE files not updated for commons-math inclusion
• NOTICE file not updated for commons-vfs2 inclusion
• LICENSE and NOTICE files not updated for jetty inclusion

accumulo-server jar / source-jar

• missing LICENSE reference for jquery/flot/sizle
• missing NOTICE for hadoop inclusion (but see not above about maybe skipping)
• missing NOTICE for thrift class inclusion

accumulo-core jar / source-jar

• missing LICENSE reference for bloom filters

all jars

• nit: jars contain NOTICE file that doesn't state the full name of the aggregate work (e.g. "Core" rather than "Apache Accumulo Core" or some such)
• jars contain NOTICE file that incorrectly states the aggregate work is copyright the Accumulo project instead of the ASF

Issue Links

• is related to: ACCUMULO-4003 1.5 native deb artifact has LICENSE/NOTICE in wrong place

Sub-Tasks

• Ensure META-INF/{LICENSE,NOTICE} files are correct in jars: Resolved
• fix source tarball LICENSE /NOTICE files: Resolved
• fix license/notice for binary tarball: Resolved
• correct license and notice files in javadoc jars: Resolved
• correct license and notice files in rpms: Resolved
• correct license and notice files in deb artifacts: Resolved
• Fix binary tarball L&N: Resolved