[ACCUMULO-3866] TraceScope not closed

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.7.1, 1.8.0
• Component/s: trace
• Labels: coverity
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 28/May/15 23:34
• Updated: 29/May/15 01:30
• Resolved: 29/May/15 01:30

Description

Two cases in which TraceScope is returned but never closed (it implements Closeable.

core/.../Trace.java

  public static void off() {
    org.apache.htrace.Span span = org.apache.htrace.Trace.currentSpan();
    if (span != null) {
      span.stop();
      org.apache.htrace.Tracer.getInstance().continueSpan(null);
    }
  }

trace/.../Trace.java

  public static void endThread(Span span) {
    if (span != null) {
      span.stop();
      org.apache.htrace.Tracer.getInstance().continueSpan(null);
    }
  }

billie.rinaldi do you know if there's a reason that these aren't getting closed or is it just a bug?