[ACCUMULO-3574] preferCachedConnections=false is not respected

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1
• Fix Version/s: 1.5.3, 1.6.3, 1.7.0
• Component/s: rpc
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 10/Feb/15 20:53
• Updated: 13/Feb/15 03:28
• Resolved: 13/Feb/15 03:28

Description

  Pair<String,TTransport> getAnyTransport(List<ThriftTransportKey> servers, boolean preferCachedConnection) throws TTransportException {
    ....
    if (!preferCachedConnection) {
      synchronized (this) {
        List<CachedConnection> cachedConnList = getCache().get(ttk);
        if (cachedConnList != null) {
          for (CachedConnection cachedConnection : cachedConnList) {
            if (!cachedConnection.isReserved()) {
              cachedConnection.setReserved(true);
              final String serverAddr = ttk.getServer().toString();
              log.trace("Using existing connection to {} timeout {}", serverAddr, ttk.getTimeout());
              return new Pair<String,TTransport>(serverAddr, cachedConnection.transport);
            }
          }
        }
      }
    }

It appears that ThriftTransportPool.getAnyTransport is returning a cache connection when the caller requested that a new connection is returned instead of a cached one.

Issue Links

• is broken by: ACCUMULO-422 Bulk import failing when tablet server dies