[ACCUMULO-3496] ZooKeeperInstance doesn't validate instance name on creation

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.6.0, 1.6.1
• Fix Version/s: 1.6.2, 1.7.0
• Component/s: client
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 19/Jan/15 17:37
• Updated: 19/Jan/15 21:16
• Resolved: 19/Jan/15 21:16

Description

ZooKeeperInstance in 1.5 contained a check when the instance name was used to ensure that a real instanceName was provided.

 public ZooKeeperInstance(String instanceName, String zooKeepers, int sessionTimeout) {
     ArgumentChecker.notNull(instanceName, zooKeepers);
     this.instanceName = instanceName;
     this.zooKeepers = zooKeepers;
     this.zooKeepersSessionTimeOut = sessionTimeout;
     zooCache = ZooCache.getInstance(zooKeepers, sessionTimeout);
     getInstanceID();
   }

The call to getInstanceID() throws an exception if the instanceName didn't exist in ZK.

In 1.6, this check no longer exists and will only happen when the ZKI is actually used (typically on getConnector(...)).

Restore the check when the instance name is provided.

Issue Links

• is broken by: ACCUMULO-1009 Support encryption over the wire
• supercedes: ACCUMULO-3495 Proxy server should verify a valid instance name before starting