[ACCUMULO-3274] MinorCompactor repeatedly toString()'s outputFile

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.1
• Fix Version/s: 1.6.5, 1.7.1, 1.8.0
• Component/s: tserver
• Labels: newbie performance
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 29/Oct/14 02:22
• Updated: 31/Dec/15 06:19
• Resolved: 31/Dec/15 06:19

Description

Noticed that MinorCompactor#call() repeatedly calls getOutputFile() which ultimately calls Path#toString() each time. This isn't very efficient since we're repeatedly calculating the same thing and creating a bunch of short-lived objects.

The output file name isn't going to change mid-MinC so the MinorCompactor should keep a local referenced to the result from a single call to getOutputFile() and use that local variable each time.