Minor Description
The current implementation of DefaultConfiguration has some downsides:
- Its internal map of configuration defaults is built on-demand in its singleton instance, which drives the need to synchronize access to the singleton. The map could be built statically.
- That same map could be made immutable as well.
- Even though it uses a singleton, new DefaultConfiguration() is still permitted since the no-arg constructor isn't defined as private.
- Calls to DefaultConfiguration.getInstance() cannot be easily mocked.
- Its main method no longer has anything to do with it, and instead belongs in ConfigurationDocGen.
Improve and simplify DefaultConfiguration.
Attachments
Issue Links
- links to
