Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-3001

Create public getters that represent "current" expected API calls/objects for InputFormat and OutputFormat

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Invalid
    • None
    • None
    • client
    • None

    Description

      Discussion: http://mail-archives.apache.org/mod_mbox/accumulo-dev/201407.mbox/%3C53C72A29.1060701%40gmail.com%3E

      All of the getters on AccumuloInputFormat and AccumuloOutputFormat are protected which prevent clients from accessing them. This is not ideal as it prevents users from introspecting the Configuration to know what values are set within the Configuration. Because elements like the concrete Input/OutputFormat class name is included in the Configuration key, this is very obtuse to try to debug.

      The reason this was done is that we often support multiple types of setters which accept a variety of method arguments for different reasons (backwards compat, usually).

      I recommend that we provide a single getter to allow users to better debug their mapreduce code. Most likely, the object returned would be the object that is currently reccomended to be used in the public API (e.g. a PasswordToken would be returned even when a user provided a plain String password).

      Attachments

        Activity

          People

            Unassigned Unassigned
            elserj Josh Elser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: